-
Notifications
You must be signed in to change notification settings - Fork 27
feat(audits): Notices section for optional recommendations #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feels like it should be ERROR > WARNING > INFO rather than ERROR > INFO > WARNING.
SHOULD assume application/json content-type when accept is missing
seems to be using GET
even on server that only support POST
, so is incorrectly triggering warnings?
Actually its INFO > WARNING > ERROR. But yeah, more importance should be given to the top. I'll reorder in a separate PR.
Will be fixed with #77. |
7614734
to
72a3a14
Compare
# [1.18.0](v1.17.1...v1.18.0) (2023-04-14) ### Bug Fixes * **audits/server:** Avoid auditing non well-formatted GraphQL-over-HTTP requests ([#62](#62)) ([d72e344](d72e344)) * **audits/server:** Prefer using POST ([#77](#77)) ([8cd7dfb](8cd7dfb)) * **handler:** Stringify errors by exposing only the message ([cabf8a9](cabf8a9)) ### Features * **audits:** Notices section for optional recommendations ([#76](#76)) ([b8bdc71](b8bdc71)) * **handler:** Error formatter function ([#78](#78)) ([c0eaeb4](c0eaeb4))
🎉 This PR is included in version 1.18.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
In light of graphql/graphql-over-http#241, after #62.